cloned-instead-of-copied

Prefer copying iterator elements whose type is Copy

Calling cloned on Copy iterator elements permits custom cloning work when intrinsic duplication is sufficient.
Instead, you SHOULD call copied to state the Copy requirement directly.

- Category: performance
- Level: warning
- Fix: automatic
- Scope: module

Reported

import { Iterator } from "destack:iter";

function copy(values: Iterator<&readonly int32>): int32[] {
    return values.cloned().toArray();
}
Accepted

import { Iterator } from "destack:iter";

function copy(values: Iterator<&readonly int32>): int32[] {
    return values.copied().toArray();
}
Prior art

- Clippy · clonedinsteadofcopied

language/linter/src/rules/performance/clonedinsteadofcopied.rs:8