manual-filter

Prefer Array.filter over manually collecting matching elements

Creating an array, conditionally pushing each input element, and returning it spells Array.filter manually.
Instead, you SHOULD return the result of filter directly.

- Category: style
- Level: warning
- Fix: suggestion
- Scope: module

Reported

function positive(values: int32[]): int32[] {
    const result: int32[] = [];
    for (const value of values) {
        if (value > 0) {
            result.push(value);
        }
    }
    return result;
}
Accepted

function positive(values: int32[]): int32[] {
    return values.filter((value) => value > 0);
}
Prior art

- Clippy · manualfilter

language/linter/src/rules/style/manualfilter.rs:8