misrefactored-assign-op

Disallow compound assignments that repeat the assigned place

A compound assignment already reads its target, so repeating that target in the assigned operation applies it twice.
Instead, you SHOULD retain only the other operand on the right-hand side.

- Category: suspicious
- Level: warning
- Fix: suggestion
- Scope: module

Reported

function add(value: int32, amount: int32): int32 {
    let result = value;
    result += result + amount;
    return result;
}
Accepted

function add(value: int32, amount: int32): int32 {
    let result = value;
    result += amount;
    return result;
}
Prior art

- Clippy · misrefactoredassignop

language/linter/src/rules/suspicious/misrefactoredassignop.rs:8