no-drop-of-trivial-value

Disallow dropping values without destructors

Calling drop for a value that requires no destruction performs no cleanup.
Instead, you SHOULD remove the call or use a narrower scope when ownership must end sooner.

- Category: suspicious
- Level: warning
- Fix: none
- Scope: module

Reported

import { drop } from "destack:memory";

function discard(value: int32): void {
    drop(value);
}
Accepted

import { Drop, drop } from "destack:memory";

struct Subscription implements Drop {
    drop(&exclusive this): void {}
}

function unsubscribe(value: Subscription): void {
    drop(value);
}
Prior art

- Clippy · dropnondrop

language/linter/src/rules/suspicious/nodropoftrivialvalue.rs:5