no-zero-iterator-drop

Disallow Iterator.drop with a constant zero count

Dropping zero values wraps an Iterator without changing the sequence it yields.
Instead, you SHOULD use the original Iterator directly.

- Category: performance
- Level: warning
- Fix: suggestion
- Scope: module

Reported

import { Iterator } from "destack:iter";

function retain(values: Iterator<int32>): Iterator<int32> {
    return values.drop(0);
}
Accepted

import { Iterator } from "destack:iter";

function retain(values: Iterator<int32>): Iterator<int32> {
    return values;
}
Prior art

- Clippy · iterskipzero

language/linter/src/rules/performance/nozeroiteratordrop.rs:8