suspicious-operand-grouping

Disallow inconsistent member pairings in comparison chains

One comparison pairing different members amid otherwise corresponding member comparisons is likely a typo.
Instead, you SHOULD compare corresponding members consistently.

- Category: suspicious
- Level: warning
- Fix: none
- Scope: module

Reported

struct Point {
    x: int32;
    y: int32;
    z: int32;
}

function equals(left: Point, right: Point): boolean {
    return left.x == right.y && left.y == right.y && left.z == right.z;
}
Accepted

struct Point {
    x: int32;
    y: int32;
    z: int32;
}

function equals(left: Point, right: Point): boolean {
    return left.x == right.x && left.y == right.y && left.z == right.z;
}
Prior art

- Clippy · suspiciousoperationgroupings

language/linter/src/rules/suspicious/suspiciousoperandgrouping.rs:7